Remove PDF export capabilities #6442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorWounds
approved these changes
May 20, 2024
deeleeramone
approved these changes
May 20, 2024
hjoaquim
approved these changes
May 21, 2024
|
I have a few updates to this PR. INCOMING!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve tested the pdf export functionality and it’s not working.
Given my prior experience with pdf export with python I decided to remove it from our export functionality on the cli and charting.
This allows us to remove reportlab and svglib from the charting deps.
This actually helped remove a vulnerable version of pillow pulled in by reportlab
Also bumped black because we have had a vulnerable version